-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bad Frac(sparse polynomial ring over finite field) #37377
Conversation
c28230a
to
8ff00fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few little details.
Thanks for your comments!
…--
Marc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. You can set a positive review after these are changed.
@@ -2483,17 +2482,14 @@ def fraction_field(self): | |||
sage: t(x) | |||
x | |||
|
|||
Issue :issue:`37374`:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue :issue:`37374`:: | |
:issue:`37374`:: |
This is redundant, including in the compiled doc.
@@ -44,16 +44,27 @@ class FpT(FractionField_1poly_field): | |||
""" | |||
INPUT: | |||
|
|||
- ``R`` -- A polynomial ring over a finite field of prime order `p` with `2 < p < 2^16` | |||
- ``R`` -- a dense polynomial ring over a finite field of prime order | |||
`p` with `2 < p < 2^16` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`p` with `2 < p < 2^16` | |
`p` with `2 < p < 2^{16}` |
Sorry, one more little thing to display properly.
On Tuesday, 20 February 2024 13:35:58 CET Travis Scrimshaw wrote:
Thanks. You can set a positive review after these are changed.
Thanks again, and sorry for missing part of your previous comments!
|
d771464
to
7774975
Compare
No problem. Thank you. |
|
This is with some additional commits merged in, right? Because I can't reproduce it with my branch alone. Anyway, I changed the test to ignore the exception test. |
Merge conflict |
The construction of the fraction field of a polynomial ring R over a small finite fields tried ot use a class dedicated to the dense case regardless whether R was dense or sparse, resulting in corrupted elements represented as dense polynomials but with a parent set to a sparse ring. In passing, add support for fraction fields of polynomial rings over prime fields based on NTL. Fixes sagemath#37374
Documentation preview for this PR (built with commit d75e9af; changes) is ready! 🎉 |
In passing, add support for fraction fields of polynomial rings over prime fields based on NTL.
Fixes #37374