sage.schemes.generic: fix docs
#37346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
reviewed
Feb 15, 2024
kwankyu
reviewed
Feb 15, 2024
kwankyu
reviewed
Feb 15, 2024
kwankyu
reviewed
Feb 15, 2024
I agree. |
|
Otherwise lgtm. |
|
Thanks! I also find a lot of violation for the two edits you suggested, I'll make another PR just for them. |
|
Sorry, the doctests are written wrong I think... let me take a look |
|
@kwankyu Do you mind re-reviewing and accepting? It's a one line change :) Thanks! |
|
Thanks. Tests pass on my system. |
|
Documentation preview for this PR (built with commit 4d248d9; changes) is ready! 🎉 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various docs problems.
I also removed the
SchemeRationalPointclass entirely since it is not used anywhere in the entire Sage library. If anyone oppose this please notify me!