-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md: Move all mentions of release tarballs to the installation guide #37309
Conversation
654af92
to
fd9c25c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few minor comments. I'm happy to approve, although I'm not sure if this should be merged yet, since the "discussion" on sage-devel is ongoing.
I'd say, let's just go ahead. Haven't seen any reaction in the thread (other than yours) |
Cloning the repo uses 1GB of disk (without any upstream packages downloaded.) Using the tarball seems more economical to me in this case. Downloading a tarball of the GitHub repo (which is not advertised anywhere) is just 28MB for me. Anyway, I don't really mind much either way. If you guys think this is a good idea, go ahead. |
no, it's "only" 615 Mb, and over 60% of it is
Adding Perhaps this is, disk space and bandwidth-wise, a better advice than the one in the PR, to use the latter.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding --filter=blob:none
to git clone options
Done in 04145de |
Co-authored-by: John H. Palmieri <[email protected]>
…l list of install commands
0fdb50b
to
3341cdb
Compare
Documentation preview for this PR (built with commit 3341cdb; changes) is ready! 🎉 |
Thanks for the review. |
As proposed in https://groups.google.com/g/sage-devel/c/5kmxaw105lg/m/liCPKG4bAQAJ
The README.md now starts with instructions to install git and then use
git clone
.📝 Checklist
⌛ Dependencies