-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sage-generate-meson
script to sage-setup
#37008
base: develop
Are you sure you want to change the base?
Conversation
As it has been explained before, the point of this script was to create the initial boilerplate code. I see value in creating a script that adds missing python and cython files. But that would require to parse the existing meson files instead of overwriting them. Something similar is already supported for other targets, just not for python. https://mesonbuild.com/Rewriter.html So I am sure the meson team would be happy to accept your PR. |
It wouldn't. Even just overwriting + then editing often has value. |
391ab83
to
fbb080b
Compare
64a0f77
to
932915a
Compare
932915a
to
a106e65
Compare
a106e65
to
21f4d94
Compare
21f4d94
to
233be89
Compare
With the |
Yes, the idea is to separate handwritten bits from autogenerated bits. |
3d77af1
to
8211f95
Compare
8211f95
to
a762cee
Compare
Documentation preview for this PR (built with commit ec43bc5; changes) is ready! 🎉 |
a762cee
to
bf27fab
Compare
bf27fab
to
2d3d5ca
Compare
I think we now have pressing needs to move to meson. This stuff looks OK, but it cannot be used in isolation. Can it even be tested without other bits for sagemath-standard? |
2d3d5ca
to
b7a8263
Compare
From PR 'Compile everything with meson' (sagemath#36524 at 46bc6b4 (2023-12-31)
…ything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
….build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
…son.build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
b7a8263
to
ec43bc5
Compare
Well, it generates files that can be compared with what has been committed to #36524. |
The script was taken from:
... where it was called
generate-meson.py
and intended to be removed before merging. #36524 (comment)Here we make it available as a script installed by
sage_setup
because what was useful once for generating code will be useful later for updating code, in particular as will be necessary for modularization concerns, as discussed in #36524 (comment)Various improvements have been made. When invoked with the switch
--monolithic
, the output maintains compatibility with #36524.Author: @tobiasdiez, @mkoeppe
📝 Checklist
⌛ Dependencies