-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "gh-36678: CI conda: Ignore baseline test failures " #36923
Conversation
Documentation preview for this PR (built with commit 29901c4; changes) is ready! 🎉 |
This nonsense really needs to stop. |
It really doesn't work this way, even if you think that a particular PR should be reverted. |
This is obviously not a blocker. |
This PR is not appropriate and is a violation of Sage's code of conduct: directly reverting a PR where you disagree with the community's decision, then giving yourself positive review with a comment that it is a "trivial git revert" is completely unacceptable. |
Reverts #36678, which was marked as "positive review" although not all reviewer concern had been addressed.
I'll set this directly as "positive review" since this is a trivial git revert.
📝 Checklist
⌛ Dependencies