Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "gh-36678: CI conda: Ignore baseline test failures " #36923

Closed

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Dec 19, 2023

Reverts #36678, which was marked as "positive review" although not all reviewer concern had been addressed.

I'll set this directly as "positive review" since this is a trivial git revert.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 29901c4; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2023

This nonsense really needs to stop.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2023

It really doesn't work this way, even if you think that a particular PR should be reverted.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 20, 2023

This is obviously not a blocker.

@tobiasdiez tobiasdiez mentioned this pull request Dec 23, 2023
5 tasks
@mkoeppe mkoeppe added r: invalid s: needs review disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ labels Dec 23, 2023
@roed314
Copy link
Contributor

roed314 commented Mar 12, 2024

This PR is not appropriate and is a violation of Sage's code of conduct: directly reverting a PR where you disagree with the community's decision, then giving yourself positive review with a comment that it is a "trivial git revert" is completely unacceptable.

@roed314 roed314 closed this Mar 12, 2024
@tobiasdiez tobiasdiez deleted the revert_conda_baseline branch March 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ r: invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants