-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.combinat
: Update # needs
#36916
Merged
vbraun
merged 8 commits into
sagemath:develop
from
mkoeppe:sage_combinat_modularization_2
Dec 26, 2023
Merged
sage.combinat
: Update # needs
#36916
vbraun
merged 8 commits into
sagemath:develop
from
mkoeppe:sage_combinat_modularization_2
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoudert
reviewed
Dec 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some warnings
sage -t --long --warn-long 29.3 --random-seed=28011800932259603920041433624003754709 src/sage/combinat/permutation.py
**********************************************************************
File "src/sage/combinat/permutation.py", line 8153, in sage.combinat.permutation.bistochastic_as_sum_of_permutations
Warning: Variable 'bistochastic_as_sum_of_permutations' referenced here was set only in doctest marked '# needs networkx sage.graphs sage.modules'
decomp = bistochastic_as_sum_of_permutations(M)
**********************************************************************
File "src/sage/combinat/permutation.py", line 8157, in sage.combinat.permutation.bistochastic_as_sum_of_permutations
Warning: Variable 'bistochastic_as_sum_of_permutations' referenced here was set only in doctest marked '# needs networkx sage.graphs sage.modules'
bistochastic_as_sum_of_permutations(Matrix(GF(7), 2, [2,1,1,2]))
**********************************************************************
File "src/sage/combinat/permutation.py", line 8161, in sage.combinat.permutation.bistochastic_as_sum_of_permutations
Warning: Variable 'bistochastic_as_sum_of_permutations' referenced here was set only in doctest marked '# needs networkx sage.graphs sage.modules'
bistochastic_as_sum_of_permutations(Matrix(ZZ, 2, [2,-1,-1,2]))
[1276 tests, 4.65 s]
Documentation preview for this PR (built with commit 182d81f; changes) is ready! 🎉 |
dcoudert
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more warnings. LGTM.
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies