Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.combinat: Update # needs #36916

Merged
merged 8 commits into from
Dec 26, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Dec 19, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some warnings

sage -t --long --warn-long 29.3 --random-seed=28011800932259603920041433624003754709 src/sage/combinat/permutation.py
**********************************************************************
File "src/sage/combinat/permutation.py", line 8153, in sage.combinat.permutation.bistochastic_as_sum_of_permutations
Warning: Variable 'bistochastic_as_sum_of_permutations' referenced here was set only in doctest marked '# needs networkx sage.graphs sage.modules'
    decomp = bistochastic_as_sum_of_permutations(M)
**********************************************************************
File "src/sage/combinat/permutation.py", line 8157, in sage.combinat.permutation.bistochastic_as_sum_of_permutations
Warning: Variable 'bistochastic_as_sum_of_permutations' referenced here was set only in doctest marked '# needs networkx sage.graphs sage.modules'
    bistochastic_as_sum_of_permutations(Matrix(GF(7), 2, [2,1,1,2]))
**********************************************************************
File "src/sage/combinat/permutation.py", line 8161, in sage.combinat.permutation.bistochastic_as_sum_of_permutations
Warning: Variable 'bistochastic_as_sum_of_permutations' referenced here was set only in doctest marked '# needs networkx sage.graphs sage.modules'
    bistochastic_as_sum_of_permutations(Matrix(ZZ, 2, [2,-1,-1,2]))
    [1276 tests, 4.65 s]

Copy link

Documentation preview for this PR (built with commit 182d81f; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more warnings. LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 25, 2023

Thank you!

@vbraun vbraun merged commit 9f286eb into sagemath:develop Dec 26, 2023
19 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants