Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various fixes in quadratic_forms (ruff, pep8, error links, etc) #36906

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

fchapoton
Copy link
Contributor

this is fixing various minor details in quadratic forms

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 0fb342a; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
… links, etc)

    
this is fixing various minor details in `quadratic forms`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36906
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 22, 2023
… links, etc)

    
this is fixing various minor details in `quadratic forms`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36906
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2023
… links, etc)

    
this is fixing various minor details in `quadratic forms`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36906
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 24, 2023
… links, etc)

    
this is fixing various minor details in `quadratic forms`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36906
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 25, 2023
… links, etc)

this is fixing various minor details in `quadratic forms`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.

URL: sagemath#36906
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit da8e1ab into sagemath:develop Dec 26, 2023
18 of 23 checks passed
@fchapoton fchapoton deleted the various_fixes_quadratic_forms branch December 26, 2023 13:15
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants