Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff auto-fixing several details in combinat folder #36898

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Dec 16, 2023

this was scripted using ruff --fix --select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat

see https://docs.astral.sh/ruff/rules/#pyupgrade-up

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few details. Otherwise, LGTM.

src/sage/combinat/composition_tableau.py Outdated Show resolved Hide resolved
src/sage/combinat/diagram_algebras.py Outdated Show resolved Hide resolved
src/sage/combinat/diagram_algebras.py Outdated Show resolved Hide resolved
src/sage/combinat/sf/sfa.py Outdated Show resolved Hide resolved
src/sage/combinat/sf/sfa.py Outdated Show resolved Hide resolved
Copy link

Documentation preview for this PR (built with commit 45b27f7; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
    
this was scripted using `ruff --fix
--select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat`

see https://docs.astral.sh/ruff/rules/#pyupgrade-up

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36898
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 22, 2023
    
this was scripted using `ruff --fix
--select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat`

see https://docs.astral.sh/ruff/rules/#pyupgrade-up

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36898
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2023
    
this was scripted using `ruff --fix
--select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat`

see https://docs.astral.sh/ruff/rules/#pyupgrade-up

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36898
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 24, 2023
    
this was scripted using `ruff --fix
--select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat`

see https://docs.astral.sh/ruff/rules/#pyupgrade-up

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36898
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 57b7771 into sagemath:develop Dec 26, 2023
20 checks passed
@fchapoton fchapoton deleted the ruff_combinat branch December 26, 2023 13:15
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants