-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruff auto-fixing several details in combinat folder #36898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoudert
suggested changes
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few details. Otherwise, LGTM.
Documentation preview for this PR (built with commit 45b27f7; changes) is ready! 🎉 |
dcoudert
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 21, 2023
this was scripted using `ruff --fix --select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat` see https://docs.astral.sh/ruff/rules/#pyupgrade-up ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36898 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 22, 2023
this was scripted using `ruff --fix --select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat` see https://docs.astral.sh/ruff/rules/#pyupgrade-up ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36898 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2023
this was scripted using `ruff --fix --select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat` see https://docs.astral.sh/ruff/rules/#pyupgrade-up ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36898 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
this was scripted using `ruff --fix --select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat` see https://docs.astral.sh/ruff/rules/#pyupgrade-up ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36898 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was scripted using
ruff --fix --select=UP009,UP018,UP034,UP039,UP025 src/sage/combinat
see https://docs.astral.sh/ruff/rules/#pyupgrade-up
📝 Checklist