Fix one doctest for giac 1.9.0-73 #36862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornaria
added
c: packages: standard
p: critical / 2
c: doctest framework
t: tests
and removed
c: doctest framework
labels
|
Documentation preview for this PR (built with commit a921710; changes) is ready! 🎉 |
mkoeppe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With giac 1.9.0-73 the output of a
symbolic_sum()test changes. Note that both answers are correct, and it's not clear that one is "better" than the other...I managed to find a way to avoid trouble (by sending the output through
factor()) so the output is the same with latest giac and earlier giac.However, fixing doctests keeps getting harder (I mean: making sure the same doctest works for different releases of dependencies). I don't have a good idea on how to improve the situation.
📝 Checklist