-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Specht modules in the tabloid basis #36748
Conversation
2b2af14
to
292c4d2
Compare
a894ec7
to
7fcf2c5
Compare
I have addressed all of the comments and added a few more doctests for the codecov (those I felt were reasonable). |
7fcf2c5
to
5c4c359
Compare
@darijgr ping? |
@tscrim, is there any reason you know of that this code is not yet in sage? |
@mantepse Lazy reviewers... |
@darijgr, do you want to look more thoroughly? For me it certainly looks "good enough" - I would be extremely surprised to see any fundamental flaws that cannot be fixed in follow up tickets. What do you think? |
I don't have time any more in this quarter :( Martin, can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
(I'll leave it up to you whether you want to allow compositions now or not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Copying this from above, because apparently, once resolved, text is not shown anymore. I agree. In fact, I now think that For example, I'll give it positive review anyway and leave this to you. |
I have two reasons for this:
Indeed.
Thank you, but I seriously considering dumping the |
Yes, I am always in favour of less duplication. |
PS: I think eventually we should have a clear framework for combinatorial objects 'naturally defined on the set [n]' and on arbitrary sets, that is used consistently for (and also walk through possibly misleading classes, eg., |
76d4032
to
ac68272
Compare
I have removed the |
the doctests, they are a failin' 🎶 |
Seems like how the error is generated changed with the changes to the submodule code. I will need to check this before updating the error message; although I feel like the error message should not be changed... |
155a950
to
95a8ed3
Compare
Come gather 'round people, wherever you roam, and finish the PR review with doctest passin'. So it was a deeper issue (and more strangely/worrisome, something I couldn't reproduce locally!). The |
Documentation preview for this PR (built with commit 95a8ed3; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's go
Merci! |
This provides an implementation of the Specht modules over arbitrary fields in the standard tableaux basis. To do so, we also implement the tabloid module, where the tabloids are implemented as
OrderedSetsPartitions
. Using this, we can construct the maximal submodule and simple submodule from a Specht module.We also implement a method to compute the Brauer character of the representations.
📝 Checklist
⌛ Dependencies