Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.modular: Update # needs, doctest cosmetics #36618

Merged
merged 5 commits into from
Nov 5, 2023
Merged

sage.modular: Update # needs, doctest cosmetics #36618

merged 5 commits into from
Nov 5, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 31, 2023 •
edited
Loading

Cherry-picked from #35095.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Oct 31, 2023
@mkoeppe mkoeppe changed the title sage.modular: Update # needs sage.modular: Update # needs, doctest cosmetics Nov 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Documentation preview for this PR (built with commit 4e33539; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way of describing input parameters could sometimes use a more standard form like

- ``name`` -- type (default: ``value``); description

but this is already much better. So I propose to let that for future PRs.

Passes all tests without warnings in modular.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 2, 2023

Thank you!

@vbraun vbraun merged commit 5151d13 into sagemath:develop Nov 5, 2023
20 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: modular forms t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @dcoudert @vbraun