Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation of Maximum Leaf Number graph parameter #36604

Merged
merged 7 commits into from
Nov 5, 2023
Merged

Calculation of Maximum Leaf Number graph parameter #36604

merged 7 commits into from
Nov 5, 2023

Conversation

MrBanananator
Copy link
Contributor

Added function to calculate the Max Leaf Number graph parameter.

Fixes #36603

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

dcoudert
dcoudert suggested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition. I have a few comments for improving the method.

src/sage/graphs/domination.py Outdated Show resolved Hide resolved
src/sage/graphs/domination.py Outdated Show resolved Hide resolved
src/sage/graphs/domination.py Outdated Show resolved Hide resolved
src/sage/graphs/domination.py Show resolved Hide resolved
src/sage/graphs/domination.py Outdated Show resolved Hide resolved
src/sage/graphs/domination.py Outdated Show resolved Hide resolved
src/sage/graphs/domination.py Outdated Show resolved Hide resolved
dcoudert
dcoudert suggested changes Nov 1, 2023
View reviewed changes
src/sage/graphs/domination.py Outdated Show resolved Hide resolved
src/sage/graphs/domination.py Outdated Show resolved Hide resolved
dcoudert
dcoudert suggested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes needed. Otherwise, it passes all tests.

src/sage/graphs/domination.py Outdated Show resolved Hide resolved
src/sage/graphs/domination.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Documentation preview for this PR (built with commit b953ed0; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding this method.

@vbraun vbraun merged commit 2230ce2 into sagemath:develop Nov 5, 2023
18 of 19 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveWitteMorris DaveWitteMorris DaveWitteMorris left review comments

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: graph theory
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

Maximum leaf number parameter
5 participants
@MrBanananator @dcoudert @DaveWitteMorris @vbraun @mkoeppe