Support giac 1.9.0-67 #36600
Merged
Support giac 1.9.0-67 #36600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 57f27a0; changes) is ready! 🎉 |
|
Running testlong now, back in about 24h. |
|
LGTM |
|
Does LGTM too. It is nice that giac is less chatty when used as a library. Still need to get those blank lines out though. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 1, 2023
The function `gb_giac()` is less noisy, so we adjust doctests in a way
they accept the noisy version (old giac) but don't fail with the silent
version (new giac).
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#36600
Reported by: Gonzalo Tornaría
Reviewer(s):
orlitzky
approved these changes
Nov 1, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 2, 2023
The function `gb_giac()` is less noisy, so we adjust doctests in a way
they accept the noisy version (old giac) but don't fail with the silent
version (new giac).
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#36600
Reported by: Gonzalo Tornaría
Reviewer(s): Michael Orlitzky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
gb_giac()is less noisy, so we adjust doctests in a way they accept the noisy version (old giac) but don't fail with the silent version (new giac).📝 Checklist