Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated name parameter in category ; capital for Coxeter #36550

Merged

Conversation

fchapoton
Copy link
Contributor

This is removing a deprecated parameter "name" in the init of "Category".

Also using the opportunity to add the capital to the name of Coxeter.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@github-actions
Copy link

Documentation preview for this PR (built with commit 092186f; changes) is ready! 🎉

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 28, 2023
…tal for Coxeter

    
This is removing a deprecated parameter "name" in the init of
"Category".

Also using the opportunity to add the capital to the name of  Coxeter.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#36550
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 29, 2023
…tal for Coxeter

    
This is removing a deprecated parameter "name" in the init of
"Category".

Also using the opportunity to add the capital to the name of  Coxeter.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#36550
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit ccb0934 into sagemath:develop Oct 31, 2023
33 of 37 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 31, 2023
@fchapoton fchapoton deleted the no-name-category-and-capital-Coxeter branch October 31, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants