-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix implicit noexcept warnings #36507
Merged
Merged
Commits on Oct 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 457b6a8 - Browse repository at this point
Copy the full SHA 457b6a8View commit details
Commits on Oct 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 31f4fa6 - Browse repository at this point
Copy the full SHA 31f4fa6View commit details
Commits on Oct 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for aaf8cac - Browse repository at this point
Copy the full SHA aaf8cacView commit details -
Fix implicit noexcept warnings (automatic)
This was generated as follows: - cythonize sagemath and save all "Implicit noexcept" warnings - sort -u and parse to produce a list of unique filename + line number - pipe the list to the following snippet: while read file line; do sed "$file" -ne "$line"p | grep -q -e noexcept -e '<.*>' || sed -i "$file" -e "$line"'s/\(\( \+\(with \|no\)gil *\)\?[:,]\?\( *#.*\)\?\)$/ noexcept\1/' done
Configuration menu - View commit details
-
Copy full SHA for d7495e2 - Browse repository at this point
Copy the full SHA d7495e2View commit details -
Minor fixes after the automatic commit.
- fix one incorrectly placed `noexcept` - fix a doctest due to code change
Configuration menu - View commit details
-
Copy full SHA for 3bd5532 - Browse repository at this point
Copy the full SHA 3bd5532View commit details -
Configuration menu - View commit details
-
Copy full SHA for 131b747 - Browse repository at this point
Copy the full SHA 131b747View commit details
Commits on Oct 25, 2023
-
Fix more implicit noexcept warnings (automatic)
The previous run only fixed files in the sagemath-standard distribution, just because we started with a list of warnings produced when compiling just sagemath-standard. This time we apply the same strategy to files in the other distributions.
Configuration menu - View commit details
-
Copy full SHA for 62c1210 - Browse repository at this point
Copy the full SHA 62c1210View commit details
Commits on Oct 27, 2023
-
Revert "disable legacy_implicit_noexcept"
This reverts commit 131b747.
Configuration menu - View commit details
-
Copy full SHA for 6ab1f92 - Browse repository at this point
Copy the full SHA 6ab1f92View commit details
Commits on Oct 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9ad02fb - Browse repository at this point
Copy the full SHA 9ad02fbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.