-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support launching notebook 7 #36506
Merged
Merged
Support launching notebook 7 #36506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for this PR (built with commit 14a70ed; changes) is ready! 🎉 |
mkoeppe
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aligns well with #36129
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 24, 2023
As reported in sagemath#36414, running `sage -notebook` fails with jupyter notebook 7. This seems to be just a matter of a changed import, which we fix. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#36414 URL: sagemath#36506 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 26, 2023
As reported in sagemath#36414, running `sage -notebook` fails with jupyter notebook 7. This seems to be just a matter of a changed import, which we fix. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#36414 URL: sagemath#36506 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 28, 2023
As reported in sagemath#36414, running `sage -notebook` fails with jupyter notebook 7. This seems to be just a matter of a changed import, which we fix. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#36414 URL: sagemath#36506 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 28, 2023
As reported in sagemath#36414, running `sage -notebook` fails with jupyter notebook 7. This seems to be just a matter of a changed import, which we fix. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#36414 URL: sagemath#36506 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 29, 2023
As reported in sagemath#36414, running `sage -notebook` fails with jupyter notebook 7. This seems to be just a matter of a changed import, which we fix. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. Fixes: sagemath#36414 URL: sagemath#36506 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #36414, running
sage -notebook
fails with jupyter notebook 7.This seems to be just a matter of a changed import, which we fix.
📝 Checklist
Fixes: #36414