Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support launching notebook 7 #36506

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Support launching notebook 7 #36506

merged 1 commit into from
Oct 31, 2023

Conversation

tornaria
Copy link
Contributor

As reported in #36414, running sage -notebook fails with jupyter notebook 7.

This seems to be just a matter of a changed import, which we fix.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

Fixes: #36414

@github-actions
Copy link

Documentation preview for this PR (built with commit 14a70ed; changes) is ready! 🎉

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aligns well with #36129

@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 23, 2023
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 24, 2023
    
As reported in sagemath#36414, running `sage -notebook` fails with jupyter
notebook 7.

This seems to be just a matter of a changed import, which we fix.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

Fixes: sagemath#36414
    
URL: sagemath#36506
Reported by: Gonzalo Tornaría
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 26, 2023
    
As reported in sagemath#36414, running `sage -notebook` fails with jupyter
notebook 7.

This seems to be just a matter of a changed import, which we fix.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

Fixes: sagemath#36414
    
URL: sagemath#36506
Reported by: Gonzalo Tornaría
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 28, 2023
As reported in sagemath#36414, running `sage -notebook` fails with jupyter
notebook 7.

This seems to be just a matter of a changed import, which we fix.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

Fixes: sagemath#36414

URL: sagemath#36506
Reported by: Gonzalo Tornaría
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 28, 2023
    
As reported in sagemath#36414, running `sage -notebook` fails with jupyter
notebook 7.

This seems to be just a matter of a changed import, which we fix.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

Fixes: sagemath#36414
    
URL: sagemath#36506
Reported by: Gonzalo Tornaría
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 29, 2023
    
As reported in sagemath#36414, running `sage -notebook` fails with jupyter
notebook 7.

This seems to be just a matter of a changed import, which we fix.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

Fixes: sagemath#36414
    
URL: sagemath#36506
Reported by: Gonzalo Tornaría
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 5b0af67 into sagemath:develop Oct 31, 2023
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants