using ruff for UP004, UP008, UP028 #36462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure that the changes to super will work ; I think I kept them as they were breaking something ; let's see |
|
Do you plan to add ruff to our linter fleet? |
|
maybe, but the CI is such a mess for the moment... |
|
merge conflict |
|
@fchapoton At least add ruff to the developer documentation please. https://doc.sagemath.org/html/en/developer/tools.html |
I worried that |
|
back to positive after trivial merge |
|
Documentation preview for this PR (built with commit e3ca71f; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 26, 2023
this was scripted using `ruff check --fix --select UP004,UP008,UP028 src/sage` here is the link to `ruff` documentation: https://docs.astral.sh/ruff/rules/ ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36462 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 28, 2023
this was scripted using `ruff check --fix --select UP004,UP008,UP028 src/sage` here is the link to `ruff` documentation: https://docs.astral.sh/ruff/rules/ ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36462 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 28, 2023
this was scripted using `ruff check --fix --select UP004,UP008,UP028 src/sage` here is the link to `ruff` documentation: https://docs.astral.sh/ruff/rules/ ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36462 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 29, 2023
this was scripted using `ruff check --fix --select UP004,UP008,UP028 src/sage` here is the link to `ruff` documentation: https://docs.astral.sh/ruff/rules/ ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36462 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was scripted using
ruff check --fix --select UP004,UP008,UP028 src/sagehere is the link to
ruffdocumentation: https://docs.astral.sh/ruff/rules/📝 Checklist