fix ZeroDivisionError in gcd of sparse polynomials #36445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpalmieri
approved these changes
Oct 12, 2023
|
Looks good to me. |
|
Thanks, John! |
2 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 15, 2023
Fixes sagemath#36427 As pointed out in sagemath#36427, attempting to calculate the gcd of two sparse polynomials raises a `ZeroDivisionError` if one of the polynomials is constant, and the other has large degree (at least 100). This is caused by an error in the code that tests whether converting either of the polynomials to FLINT will be very slow. To fix this, we check each polynomial individually, instead of trying to consider both polynomials at once. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. URL: sagemath#36445 Reported by: DaveWitteMorris Reviewer(s): John H. Palmieri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 17, 2023
Fixes sagemath#36427 As pointed out in sagemath#36427, attempting to calculate the gcd of two sparse polynomials raises a `ZeroDivisionError` if one of the polynomials is constant, and the other has large degree (at least 100). This is caused by an error in the code that tests whether converting either of the polynomials to FLINT will be very slow. To fix this, we check each polynomial individually, instead of trying to consider both polynomials at once. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. URL: sagemath#36445 Reported by: DaveWitteMorris Reviewer(s): John H. Palmieri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36427
As pointed out in #36427, attempting to calculate the gcd of two sparse polynomials raises a
ZeroDivisionErrorif one of the polynomials is constant, and the other has large degree (at least 100).This is caused by an error in the code that tests whether converting either of the polynomials to FLINT will be very slow. To fix this, we check each polynomial individually, instead of trying to consider both polynomials at once.
📝 Checklist