Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/sage/parallel/map_reduce.py: replace tmp_dir() #36437

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

orlitzky
Copy link
Contributor

Standard tempfile.TemporaryDirectory() replacement for tmp_dir() and fix a deprecation warning while we're at it.

Issue: #36322

Fixes a DeprecationWarning:

  DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
    logger.warn(f"Profiling in {output} ...")
Standard tempfile.TemporaryDirectory() replacement.

Issue: sagemath#36322
@github-actions
Copy link

Documentation preview for this PR (built with commit ee0d8ef; changes) is ready! 🎉

Copy link
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 15, 2023
    
Standard `tempfile.TemporaryDirectory()` replacement for `tmp_dir()` and
fix a deprecation warning while we're at it.

Issue: sagemath#36322
    
URL: sagemath#36437
Reported by: Michael Orlitzky
Reviewer(s): Marc Mezzarobba
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 17, 2023
    
Standard `tempfile.TemporaryDirectory()` replacement for `tmp_dir()` and
fix a deprecation warning while we're at it.

Issue: sagemath#36322
    
URL: sagemath#36437
Reported by: Michael Orlitzky
Reviewer(s): Marc Mezzarobba
@vbraun vbraun merged commit 12069d0 into sagemath:develop Oct 21, 2023
23 of 33 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 21, 2023
@orlitzky orlitzky deleted the no-tmp-dir9 branch October 23, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants