Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError doctests when output includes a suggestion (part of python 3.12 support) #36403

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Fix AttributeError doctests when output includes a suggestion (part of python 3.12 support) #36403

merged 2 commits into from
Oct 14, 2023

Commits on Oct 8, 2023

  1. py312: fix AttributeError doctests (sed changes) 

    In python 3.12, attribute errors add a suggestion at the end of the
usual error message ("Did you mean ...?").

We add ... at the end of these doctest outputs to fix it.

This commit has the bulk of the changes, obtained with:

    git grep -l "AttributeError:" src | xargs sed -ie \
        's/^ *\(AttributeError: .*\)\?has no attribute.*$/&.../'
    @mkoeppe
    mkoeppe committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    92088d3 View commit details
    Browse the repository at this point in the history

  2. py312: fix AttributeError doctests (manual changes) 

    In python 3.12, attribute errors add a suggestion at the end of the
usual error message ("Did you mean ...?").

We add ... at the end of these doctest outputs to fix it.

This commit has a few manual changes which didn't match the sed pattern
in the previous commit.
    @tornaria
    tornaria authored and Matthias Koeppe committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    5e34da9 View commit details
    Browse the repository at this point in the history