Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh the cython file real_roots (pep8, range, etc) #36374

Merged
merged 3 commits into from
Oct 8, 2023
Merged

refresh the cython file real_roots (pep8, range, etc) #36374

merged 3 commits into from
Oct 8, 2023

Conversation

fchapoton
Copy link
Contributor

just refreshing a little bit the code in the modified file

  • using range at some place (partial)
  • fix all cython-lint warnings

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

dcoudert
dcoudert reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM.

The doctest errors reported by the CI are independent from the changes done here.

src/sage/rings/polynomial/real_roots.pyx Outdated

for (oc, factor, exp) in oceans: oc.find_roots()
for (oc, factor, exp) in oceans:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove parenthesis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voila, voila. Merci pour tes nombreuses relectures !

dcoudert
dcoudert approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Documentation preview for this PR (built with commit f8d3154; changes) is ready! 🎉

@vbraun vbraun merged commit bc8d82a into sagemath:develop Oct 8, 2023
21 of 23 checks passed
@fchapoton fchapoton deleted the real_roots_fresh branch October 8, 2023 14:35
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe