Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some class roles for linking Errors in doc #36336

Merged
merged 1 commit into from
Sep 27, 2023
Merged

add some class roles for linking Errors in doc #36336

merged 1 commit into from
Sep 27, 2023

Conversation

fchapoton
Copy link
Contributor

this is adding a few class roles so that errors in the doc are linked to python documentation

Here done mostly for TypeError

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions
Copy link

Documentation preview for this PR (built with commit 93e54a5; changes) is ready! 🎉

dcoudert
dcoudert reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor point. Otherwise, LGTM.

src/sage/structure/parent_old.pyx
x -- Python object
v -- parent object or list (iterator) of parent objects

- x -- Python object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x -> ``x``

@fchapoton
Copy link
Contributor Author

well, this is inside a deprecated function anyway...

dcoudert
dcoudert approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. So then, I agree with these changes.

@vbraun vbraun merged commit a9cb852 into sagemath:develop Sep 27, 2023
22 of 25 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 27, 2023
@fchapoton fchapoton deleted the add_some_link_for_errors branch September 28, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: documentation
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe