Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sage.finance, deprecated in #32427 (2021) #36303

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Sep 19, 2023

This completes the work of #32427.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Sep 19, 2023
@orlitzky
Copy link
Contributor

It looks like the doctest change in graphique_doctest.py caused a failure:

2023-09-20T00:41:16.0190598Z Failed example:
2023-09-20T00:41:16.0191032Z     sage.stats.time_series.TimeSeries(liste).plot_histogram(bins=20)
2023-09-20T00:41:16.0191441Z Exception raised:
2023-09-20T00:41:16.0191812Z     Traceback (most recent call last):
2023-09-20T00:41:16.0192252Z       File "/sage/src/sage/doctest/forker.py", line 709, in _run
2023-09-20T00:41:16.0192741Z         self.compile_and_execute(example, compiler, test.globs)
2023-09-20T00:41:16.0193226Z       File "/sage/src/sage/doctest/forker.py", line 1144, in compile_and_execute
2023-09-20T00:41:16.0193662Z         exec(compiled, globs)
2023-09-20T00:41:16.0194412Z       File "<doctest sage.tests.books.computational-mathematics-with-sagemath.graphique_doctest[26]>", line 1, in <module>
2023-09-20T00:41:16.0195111Z         sage.stats.time_series.TimeSeries(liste).plot_histogram(bins=Integer(20))
2023-09-20T00:41:16.0195554Z         ^^^^^^^^^^^^^^^^^^^^^^
2023-09-20T00:41:16.0196786Z     AttributeError: module 'sage.stats' has no attribute 'time_series'

@github-actions
Copy link

Documentation preview for this PR (built with commit 6c88c8e; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 20, 2023

The failure in qqbar is unrelated

@orlitzky
Copy link
Contributor

OK

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 21, 2023

Thanks!

@vbraun vbraun merged commit 53cce67 into sagemath:develop Sep 24, 2023
17 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants