Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate args in @options() in region_plot #36296

Merged
merged 3 commits into from
Sep 24, 2023

Commits on Sep 18, 2023

  1. remove duplicate args in @options() in region_plot

    This is needed for Sphinx 7.1+
    dimpase committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    beb94bc View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Configuration menu
    Copy the full SHA
    80fd0a9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'region_plot' of github.com:egourgoulhon/sage into optio…

    …ns_fix_in_contour_plot
    
    This also fixes a bug in region_plot, so that plot_points are not
    passed in calls to other functions via options.
    
    This is because a @options decorator's argument are automatically popped
    from "options" dict as soon as the function it decorates has an arg
    with the same name.
    
    In the change we reduce the number of positional arguments of
    region_plot; thus the corresponding args of @options have to be popped
    manually in the function body; we don't pop plot_points, to
    pass it correctly in function calls.
    dimpase committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b7c6367 View commit details
    Browse the repository at this point in the history