Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no generator for S1 #36252

Merged
merged 2 commits into from
Sep 24, 2023
Merged

no generator for S1 #36252

merged 2 commits into from
Sep 24, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Sep 11, 2023

Trying to explain that the symmetric group S(1) has no generator

fixes #36204

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.

@fchapoton
Copy link
Contributor Author

this still needs some work to fix doctests

@fchapoton
Copy link
Contributor Author

almost working, still 3 failing doctests in sage/groups/finitely_presented_named.py

@github-actions
Copy link

Documentation preview for this PR (built with commit 4a196cf; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM,

@tscrim tscrim added this to the sage-10.2 milestone Sep 17, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tscrim approved this PR

@vbraun vbraun merged commit 5bd0466 into sagemath:develop Sep 24, 2023
15 of 17 checks passed
@fchapoton fchapoton deleted the no_gen_for_S1 branch September 25, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not create group homomorphism with trivial symmetric group as domain
3 participants