Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self-cimports #36207

Merged
merged 7 commits into from
Sep 10, 2023
Merged

Remove self-cimports #36207

merged 7 commits into from
Sep 10, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Sep 7, 2023

Some Cython modules contain redundant cimport statements that cimport from themselves - directly or indirectly.

We remove them and make some related cleanups of imports/cimports.

This helps with Cython 3.0.2, in which the self-cimports trigger surprising behavior in the presence of implicit namespace packages.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Documentation preview for this PR (built with commit 1ba481b; changes) is ready! 🎉

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@mkoeppe mkoeppe self-assigned this Sep 8, 2023
@vbraun vbraun merged commit 7bd147d into sagemath:develop Sep 10, 2023
14 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 10, 2023
@fchapoton
Copy link
Contributor

maybe the changes in src/sage/graphs/comparability.pyx are causing problems ? we see some failures there in our broken CI right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants