Fix quadratic memory of berlekamp_massey #36173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
reviewed
Sep 1, 2023
|
@dima, would you approve the workflows? (or could you give me the privilege to grant the approval?) |
The test has been reflected in the PR on GitHub.
kwankyu
reviewed
Sep 1, 2023
|
Documentation preview for this PR (built with commit 0293a38; changes) is ready! 🎉 |
kwankyu
approved these changes
Sep 3, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 4, 2023
Fix sagemath#36172. Reduced berlekamp_massey memory consumption by replacing a dictionary with temporary variables. The memory consumption of the line highlighted below reduced from 42MB to 4MB (probably inaccurate, but significant enough). ```python from memory_profiler import profile from sage.matrix.berlekamp_massey import berlekamp_massey @Profile def gen_data(): p = random_prime(2**64) ls = [GF(p).random_element() for _ in range(20000)] berlekamp_massey(ls); # <--- this line gen_data() ``` I am not sure if I have to include extra doctests or not, or how to test memory consumptions, since the time complexity is also O(n^2). ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#36173 Reported by: grhkm21 Reviewer(s): grhkm21, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 5, 2023
Fix sagemath#36172. Reduced berlekamp_massey memory consumption by replacing a dictionary with temporary variables. The memory consumption of the line highlighted below reduced from 42MB to 4MB (probably inaccurate, but significant enough). ```python from memory_profiler import profile from sage.matrix.berlekamp_massey import berlekamp_massey @Profile def gen_data(): p = random_prime(2**64) ls = [GF(p).random_element() for _ in range(20000)] berlekamp_massey(ls); # <--- this line gen_data() ``` I am not sure if I have to include extra doctests or not, or how to test memory consumptions, since the time complexity is also O(n^2). ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#36173 Reported by: grhkm21 Reviewer(s): grhkm21, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36172.
Reduced berlekamp_massey memory consumption by replacing a dictionary with temporary variables. The memory consumption of the line highlighted below reduced from 42MB to 4MB (probably inaccurate, but significant enough).
I am not sure if I have to include extra doctests or not, or how to test memory consumptions, since the time complexity is also O(n^2).
📝 Checklist