Fix reduction of cusps for Gamma(N) #36165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit bf08b12; changes) is ready! 🎉 |
fchapoton
approved these changes
Sep 12, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 14, 2023
The method reduce_cusp for Gamma(N) did not work properly on cusps u/v where (u,v) is congruent to (-1,0) mod N. This fixes that by fixing the function _lift_pair(). A doctest has been added with the example reported on sage-devel. Fixes sagemath#36163 ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#36165 Reported by: John Cremona Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method reduce_cusp for Gamma(N) did not work properly on cusps u/v where (u,v) is congruent to (-1,0) mod N. This fixes that by fixing the function _lift_pair(). A doctest has been added with the example reported on sage-devel.
Fixes #36163
📝 Checklist