Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the 2 broken linters #36148

Merged
merged 4 commits into from
Sep 1, 2023
Merged

fix the 2 broken linters #36148

merged 4 commits into from
Sep 1, 2023

Conversation

fchapoton
Copy link
Contributor

This repairs the two broken linters.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@@ -547,7 +547,7 @@ cdef class Polynomial_ZZ_pEX(Polynomial_template):
def inverse_series_trunc(self, prec):
r"""
Compute and return the inverse of self modulo `x^prec`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it should be x^{prec} here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voilà, voilà

@dcoudert
Copy link
Contributor

failing doctest

sage -t --long --random-seed=286735480429121101562228604801325644303 sage/dynamics/arithmetic_dynamics/dynamical_semigroup.py
**********************************************************************
File "sage/dynamics/arithmetic_dynamics/dynamical_semigroup.py", line 933, in sage.dynamics.arithmetic_dynamics.dynamical_semigroup.DynamicalSemigroup.__mul__
Failed example:
    f*g
Expected:
    Traceback (most recent call last):
    ...
    TypeError: can only multiply dynamical semigroups with other dynamical semigroups of the same type
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/sage/src/sage/doctest/forker.py", line 709, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/sage/src/sage/doctest/forker.py", line 1144, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.dynamics.arithmetic_dynamics.dynamical_semigroup.DynamicalSemigroup.__mul__[46]>", line 1, in <module>
        f*g
        ~^~
      File "/sage/src/sage/dynamics/arithmetic_dynamics/dynamical_semigroup.py", line 967, in __mul__
        raise ValueError("left dynamical semigroup's domain must equal right dynamical semigroup's codomain")
    ValueError: left dynamical semigroup's domain must equal right dynamical semigroup's codomain
**********************************************************************
1 item had failures:
   1 of  62 in sage.dynamics.arithmetic_dynamics.dynamical_semigroup.DynamicalSemigroup.__mul__
    [398 tests, 1 failure, 5.31 s]

still compare types (beurk)
@EnderWannabe
Copy link
Contributor

Changes look good to me.

@github-actions
Copy link

Documentation preview for this PR (built with commit 3bf709c; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 952696e into sagemath:develop Sep 1, 2023
13 of 14 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 1, 2023
@fchapoton fchapoton deleted the fix_linters branch September 2, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants