Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-style loops in sage.graphs #36142

Merged
merged 3 commits into from
Sep 1, 2023
Merged

python-style loops in sage.graphs #36142

merged 3 commits into from
Sep 1, 2023

Conversation

dcoudert
Copy link
Contributor

Convert the loops of the form for x from 0 <= x < n in sage.graphs to python-style loops.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Aug 26, 2023
@fchapoton
Copy link
Contributor

I do not understand why the checks are not running..

@dcoudert
Copy link
Contributor Author

Me neither. I already saw that for instance in #35990.

@fchapoton
Copy link
Contributor

can you please tell me if sage builds and the doctests pass in src/graphs ?

@dcoudert
Copy link
Contributor Author

Yes I can compile and all doctests pass on graphs on my laptop. Furthermore, the GitHub bot has launched the tests. Wait and see ;)

@github-actions
Copy link

Documentation preview for this PR (built with commit a179563; changes) is ready! 🎉

fchapoton
fchapoton approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, merci. Feu vert

@dcoudert
Copy link
Contributor Author

Merci à toi.

@vbraun vbraun merged commit 1a76c80 into sagemath:develop Sep 1, 2023
9 of 12 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees

@dcoudert dcoudert

Labels
c: graph theory
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@dcoudert @fchapoton @vbraun @mkoeppe