Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some details in quadratic forms #36108

Merged
merged 1 commit into from
Aug 27, 2023
Merged

some details in quadratic forms #36108

merged 1 commit into from
Aug 27, 2023

Conversation

fchapoton
Copy link
Contributor

This is fixing a few minor details in quadratic forms, about

  • unused variables found by pylint
  • strange re-definitions of ZZ and QQ

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@github-actions
Copy link

Documentation preview for this PR (built with commit 1cbabd3; changes) is ready! 🎉

kwankyu
kwankyu approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 3c6a36a into sagemath:develop Aug 27, 2023
14 of 15 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Aug 27, 2023
@fchapoton fchapoton deleted the some_details_in_quadforms branch August 28, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees
No one assigned
Labels
c: quadratic forms
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @kwankyu @vbraun @mkoeppe