-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Height function for projective subvarieties #36094
Conversation
Is @guojing0 the author of the code, but you @MatheMagicianPi created this PR in behalf of him? If so, then did you notice him personally about this? I am asking these because I wonder how credits problem should be handled. |
Hi @kwankyu, you are right that @guojing0 is the author of the code. These functions began as part of his GSoC 2022 project on height functions which I helped supervise. I prompted Dang (@MatheMagicianPi) to create this pull request on his behalf to try and close this issue, as Jing is currently working on other issues. I'm happy to defer to your judgement on how code should be credited. |
Some people use "Assignees" to give credits to all those involved in a PR resolving an issue. It is unfortunate that it is not "Contributors" or "Authors", but it seem the best we can do in the GitHub system. So I assigned both of them to "Assignees". By the way, I think it is all right that you review this PR unless you prefer others. |
default RealField precision). | ||
OUTPUT: | ||
- a real number. | ||
EXAMPLES:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no spaces separating parts of the docstring here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard in
https://doc.sagemath.org/html/en/developer/coding_basics.html#template
(also many examples in the file being modified) suggests blank lines just below INPUT:
and OUTPUT:
.
Thanks. On more thing: as
Otherwise, it looks good to me. |
Documentation preview for this PR (built with commit bf3b9a1; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Direct transfer from #34559. Methods implemented: local_height, local_height_arch, global_height.
Fixes #34559📝 Checklist
⌛ Dependencies