-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.groups.perm_gps.partn_ref*
: Modularization fixes
#35881
Conversation
…pport code, avoid use of FLINT
15271b6
to
e11afa7
Compare
""" | ||
cdef int i = 0, j = 0, location = 0, n = PS.degree | ||
bitset_zero(b) | ||
while 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while True
might be better.
Furthermore, this loop has no control on the max value of I
. Isn't it safer to use a for
loop combined with a else
statement to raise an error in case break
is never called ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made these (and other) style fixes.
I also tested with an assert i < PS.degree
at the end of the while loops and ran the tests for the faulty random seed reported in https://groups.google.com/g/sage-release/c/4mtUN8Rz92o/m/FLXKh321BgAJ; the assertion held, so at least this is not related.
I don't think I want to put the assertion there permanently though
Documentation preview for this PR (built with commit 526efac; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you! |
📚 Description
partn_ref2
depends onsage.libs.gap
.We restore the independence of
partn_ref
fromsage.libs.gap
by creating a separate function for the case ofPS_first_smallest
with non-None
partn_ref_alg
inpartn_ref2
.We also remove the compile-time dependency on flint.
📝 Checklist
⌛ Dependencies