Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.matrix.misc: Split by library dependency #35758

Merged
merged 4 commits into from
Jun 21, 2023
Merged

sage.matrix.misc: Split by library dependency #35758

merged 4 commits into from
Jun 21, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 13, 2023 •
edited
Loading

📚 Description

Fixes a modularization anti-pattern:
Unrelated functions with separate library dependencies gathered in one file.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe requested a review from tscrim June 13, 2023 05:48
@mkoeppe mkoeppe self-assigned this Jun 13, 2023
@github-actions
Copy link

Documentation preview for this PR (built with commit 75d0cdc) is ready! 🎉

@mkoeppe mkoeppe requested a review from dcoudert June 15, 2023 15:42
dcoudert
dcoudert approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 15, 2023

Thank you!

@vbraun vbraun merged commit 277d965 into sagemath:develop Jun 21, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

@tscrim tscrim Awaiting requested review from tscrim

Assignees

@mkoeppe mkoeppe

Labels
c: linear algebra t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.

Refactor sage.matrix.misc
3 participants
@mkoeppe @dcoudert @vbraun