-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept system openblas 0.3.23 and newer (needed for archlinux) #35524
Conversation
I'm not sure how to handle the pkg-config case (the syntax is not very flexible). |
Marking this as critical because on archlinux, we neither accept the system openblas nor are able to build our own openblas (#34899) |
2394031
to
a1404d9
Compare
… in the non-pkgconfig branch
Documentation preview for this PR is ready! 🎉 |
Thanks! |
I'm on Archlinux and facing the same issue as described. I previously built sage successfully from source when the OpenBLAS version was 0.3.21 and the OpenBLAS was built from https://aur.archlinux.org/packages/openblas-lapack . What can be a workaround at the present? |
you need to pull the branch of this PR, have you done it? |
After many trials, I went with the official repository packages for openblas and lapack and was able to successfully build sage after cleaning the previous build files and everything seems to be working fine now. Should I also try using this method? Note that I'm unable to build the 0.3.23 package for OpenBLAS as mentioned above so this was the only resort and openblas didn't install through the sage build. Am I missing something? (This was started before your comment so I waited for this build). |
official - as your OS (Archlinux) official, or upstream (OpenBLAS) official? |
I'm referring to the Archlinux package repository here. The upstream project only provides official binary packages for Windows. |
OK then - this PR is exactly for this purpose. |
📚 Description
The configure script was updated to reject openblas 0.3.22 but the test introduced in #35377 is too restrictive and excludes openblas 0.3.23.
This patch addresses the issue for the non
pkg-config
case (currently on Archlinux,openblas.pc
has no version number andpkg-config
is not used in the configure process).📝 Checklist
⌛ Dependencies