Rewrite wrapping class for NTL ZZ_pX using Polynomial_template #35393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This patch is a major rewrite of the NTL Z/nZ polynomial class using the same framework as
polynomial_zz_pex
andpolynomial_zmod_flint
. The rationale for this change is:Polynomial_dense_modn_ntl_ZZ
andPolynomial_dense_mod_p
share a base class, but their data layout is completely different and base methods are incompatible_derivative
is only used for composite moduliThe change was made by cloning the ZZ_pEX linkage template, then trimming redundant code and moving doctests to more appropriate places. The
ZZ_pContext
is stored inself._parent._modulus
.Visible changes include:
ntl_set_directly
andntl_ZZ_pX
derivative()
is now much faster on mod p polynomials (thanks to NTL)mul_trunc
is now faster by truncating polynomials before calling NTL📝 Checklist
⌛ Dependencies
This PR is large so it may conflict with other patches such as #35389 and #35340