-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to squarefree_decomposition() for finite fields. #35334
Improvements to squarefree_decomposition() for finite fields. #35334
Conversation
It's amazing what a little bit of Cython and avoiding unnecessary calls can do. |
Hello, the code change looks OK. By the way I am finalizing a patch to link with NTL for |
Feel free to put me as a reviewer once that PR is ready. |
Documentation preview for this PR is ready! 🎉 |
All tests pass. @remyoudompheng Did you intend to approve this PR or should this wait for your upcoming change? |
LGTM. The upcoming change is independent. |
Thank you. Can you also approve the PR? In principle I can do it, but it feels a bit weird. |
Thanks! |
📚 Description
We make some optimizations to the computation of
squarefree_decomposition()
for polynomials over finite fields. This is a followup to #35323.We make improvements by only getting the parent of
T0
once and manually keep track of its degree.The current branch
versus with #35323:
versus 10.0.beta5:
📝 Checklist
⌛ Dependencies