Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyscipopt: Update to 4.3.0, use tarball without generated .c files, run Cython instead #35303

Merged
merged 3 commits into from
Apr 1, 2023

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Mar 17, 2023

📚 Description

pyscipopt's tarball has generated with an old Cython .c files. This breaks it on Python 3.11+, see
#35299

This fixes #35299 by switching to a tarball without .c files.

📝 Checklist

  • [x ] I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • [x ] I have linked an issue or discussion.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (f449b14) 88.62% compared to head (c53044b) 88.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35303      +/-   ##
===========================================
- Coverage    88.62%   88.61%   -0.01%     
===========================================
  Files         2148     2148              
  Lines       398653   398653              
===========================================
- Hits        353308   353284      -24     
- Misses       45345    45369      +24     

see 26 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 17, 2023

You need to change the tarball line in checksums.ini because a file of this name is already on our mirrors and does not have the right checksum

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 17, 2023

and now 4.3.0 is out

@mantepse
Copy link
Collaborator

works for me! Thank you!

@dimpase
Copy link
Member Author

dimpase commented Mar 17, 2023

and now 4.3.0 is out

with 7.6MB scip.c file in PyPI tarball 🤦🏽‍♂️

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 17, 2023

We can just keep using the github tarball

@dimpase
Copy link
Member Author

dimpase commented Mar 17, 2023

We can just keep using the github tarball

I'm curios how they manage to keep these C files in. I can't figure it out.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 17, 2023

Their setup.py generates the .c file unconditionally, no matter what command is passed to setup.py.

@dimpase
Copy link
Member Author

dimpase commented Mar 17, 2023

I don't know, but I don't get this issue on https://github.com/dimpase/primecountpy

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 17, 2023

Yes, because there you call cythonize from within build_ext.

@dimpase
Copy link
Member Author

dimpase commented Mar 17, 2023

would upstream accept such a change for pyscipopt?

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 17, 2023

They accepted some other build system work that I sent as PRs

@mkoeppe mkoeppe changed the title use pyscipopt's tarball without generated .c files: run up to date Cython instead pyscipopt: Update to 4.3.0, use tarball without generated .c files, run Cython instead Mar 18, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: c53044b

@vbraun vbraun merged commit bbedc68 into sagemath:develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyscipopt does not work with Python 3.11
5 participants