-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyscipopt
: Update to 4.3.0, use tarball without generated .c files, run Cython instead
#35303
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #35303 +/- ##
===========================================
- Coverage 88.62% 88.61% -0.01%
===========================================
Files 2148 2148
Lines 398653 398653
===========================================
- Hits 353308 353284 -24
- Misses 45345 45369 +24 see 26 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
You need to change the |
and now 4.3.0 is out |
works for me! Thank you! |
with 7.6MB |
We can just keep using the github tarball |
I'm curios how they manage to keep these C files in. I can't figure it out. |
Their |
I don't know, but I don't get this issue on https://github.com/dimpase/primecountpy |
Yes, because there you call |
would upstream accept such a change for |
They accepted some other build system work that I sent as PRs |
pyscipopt
: Update to 4.3.0, use tarball without generated .c files, run Cython instead
Documentation preview for this PR is ready! 🎉 |
📚 Description
pyscipopt's tarball has generated with an old Cython .c files. This breaks it on Python 3.11+, see
#35299
This fixes #35299 by switching to a tarball without .c files.
📝 Checklist