Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Docker images published on ghcr.io without 'docker' in the name (step 3) #35278

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Use the Docker images published on ghcr.io without 'docker' in the name (step 3) #35278

merged 1 commit into from
Apr 1, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 14, 2023 •
edited
Loading

📚 Description

Step 3 of the rename done in #35079 and #35080.

This will speed up the "Build & Test" and "Build documentation" workflows because they will start from more recent images.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Mar 14, 2023
@mkoeppe mkoeppe requested a review from dimpase March 27, 2023 23:58
dimpase
dimpase approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 28, 2023

Thanks!

@vbraun vbraun merged commit 8429622 into sagemath:develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees

@mkoeppe mkoeppe

Labels
p: critical / 2
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @dimpase @vbraun