Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.manifolds, sage.tensor: Add # optional doctest tags for modularization #35267

Merged
merged 15 commits into from
Apr 1, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 11, 2023

📚 Description

Adding tags that make it possible/meaningful to doctest sage.manifolds, sage.tensor even when some "standard" packages (pplpy, the modularized distribution packaging providing sage.symbolic and sage.manifolds) are not installed. Also taking care of sage.geometry.riemannian_manifolds.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

This is just two commits on top of:

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 2c7ad61

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 98.07% and project coverage change: +0.01 🎉

Comparison is base (52a81cb) 88.57% compared to head (2c7ad61) 88.58%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35267      +/-   ##
===========================================
+ Coverage    88.57%   88.58%   +0.01%     
===========================================
  Files         2140     2141       +1     
  Lines       397273   397416     +143     
===========================================
+ Hits        351891   352061     +170     
+ Misses       45382    45355      -27     
Impacted Files Coverage Δ
src/sage/features/__init__.py 95.18% <ø> (ø)
src/sage/features/all.py 100.00% <ø> (ø)
src/sage/features/bliss.py 100.00% <ø> (ø)
src/sage/features/cddlib.py 100.00% <ø> (ø)
src/sage/features/csdp.py 40.74% <ø> (ø)
src/sage/features/cython.py 100.00% <ø> (ø)
src/sage/features/databases.py 96.15% <ø> (-0.15%) ⬇️
src/sage/features/dvipng.py 100.00% <ø> (ø)
src/sage/features/ffmpeg.py 22.58% <ø> (-2.42%) ⬇️
src/sage/features/gfan.py 100.00% <ø> (ø)
... and 83 more

... and 26 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@egourgoulhon egourgoulhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for sage.manifolds and sage.tensor parts.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 13, 2023

Thank you!

@vbraun
Copy link
Member

vbraun commented Mar 29, 2023

sage -t --long --warn-long 73.8 --random-seed=123 src/sage/interfaces/r.py  # 3 doctests failed

@vbraun vbraun merged commit be6021d into sagemath:develop Apr 1, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants