Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add best-practices for PR titles to PR template #35022

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Add best-practices for PR titles to PR template #35022

merged 1 commit into from
Feb 8, 2023

Conversation

tobiasdiez
Copy link
Contributor

📚 Description

Add a short guideline on how to write good PR titles. Refs #34983 (comment).

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez tobiasdiez mentioned this pull request Feb 8, 2023
Merged
3 tasks
dimpase
dimpase approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard to preview, so let's merge it blindly :-)

@dimpase
Copy link
Member

dimpase commented Feb 8, 2023

important workflow fix, merging

@dimpase dimpase merged commit 104dde9 into sagemath:develop Feb 8, 2023
@tobiasdiez tobiasdiez deleted the pr-template-title branch February 8, 2023 10:55
@mkoeppe mkoeppe added this to the sage-9.8 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sage-9.8
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasdiez @dimpase @kwankyu @mkoeppe