Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finite field relative #34992

Draft
wants to merge 144 commits into
base: develop
Choose a base branch
from
Draft

Conversation

roed314
Copy link
Contributor

@roed314 roed314 commented Feb 6, 2023

Fixes #28485.

saraedum and others added 30 commits September 12, 2019 16:26
a first draft that tries to restore some sanity in the factory code
mostly
as it interferes with the one we inhertit from the general ring
extension.
so it does not interfere with code inherited from the general extension
framework
with Python 3 we'd see the underlying error. However, at the moment it's
quite annoying that we cannot see what caused the ValueError.
so a few more extensions work (again)
polynomial.change_ring(R) produces a polynomial over R even if R is a
polynomial ring (and even if R is polynomial.parent())

in the same way polynomial.change_ring(hom) now produces a polynomial
over hom.codomain()
for the sake of testing GitLab Web IDE
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 89fcf83

@roed314
Copy link
Contributor Author

roed314 commented Mar 28, 2023

Keep which methods? is_Polynomial was deprecated in a separate PR that has already been merged into Sage; I'm just removing its use from library code to get rid of doctest failures.

@xcaruso
Copy link
Contributor

xcaruso commented Mar 29, 2023

Sorry! I post my message in the wrong PR.

(I used for the first time yesterday the command gh in the terminal and I forgot to give the number of the PR as an argument. I don't why my message was eventually posted here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MR33: Relative Extensions of Finite Fields
7 participants