Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse strategies for composite elliptic-curve isogenies #34965

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Feb 6, 2023

Fixes #34239.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 88.58% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b52a631) compared to base (293dd72).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34965      +/-   ##
===========================================
- Coverage    88.58%   88.58%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396961   396964       +3     
===========================================
- Hits        351655   351643      -12     
- Misses       45306    45321      +15     
Impacted Files Coverage Δ
src/sage/schemes/elliptic_curves/hom_composite.py 91.76% <100.00%> (+0.14%) ⬆️
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/groups/additive_abelian/qmodnz.py 91.48% <0.00%> (-2.13%) ⬇️
src/sage/cpython/_py2_random.py 74.38% <0.00%> (-1.66%) ⬇️
src/sage/graphs/generators/random.py 91.09% <0.00%> (-1.20%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/graphs/generic_graph.py 89.02% <0.00%> (-0.50%) ⬇️
src/sage/rings/polynomial/ore_polynomial_ring.py 89.40% <0.00%> (-0.43%) ⬇️
src/sage/quadratic_forms/ternary_qf.py 66.92% <0.00%> (-0.39%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JohnCremona
Copy link
Member

LGTM but I think @defeo should look at it too.

@yyyyx4 yyyyx4 force-pushed the public/sparse_strategies_for_composite_elliptic_curve_isogenies branch from b52a631 to 08a832b Compare February 16, 2023 09:02
@yyyyx4 yyyyx4 force-pushed the public/sparse_strategies_for_composite_elliptic_curve_isogenies branch 2 times, most recently from a5dd7c6 to 810208a Compare April 7, 2023 01:22
@yyyyx4 yyyyx4 force-pushed the public/sparse_strategies_for_composite_elliptic_curve_isogenies branch from 810208a to 6dd2b93 Compare April 14, 2023 03:11
@yyyyx4 yyyyx4 force-pushed the public/sparse_strategies_for_composite_elliptic_curve_isogenies branch from 6dd2b93 to d319082 Compare May 17, 2023 04:32
@yyyyx4 yyyyx4 force-pushed the public/sparse_strategies_for_composite_elliptic_curve_isogenies branch from d319082 to e3d17c3 Compare May 24, 2023 05:08
@kwankyu
Copy link
Collaborator

kwankyu commented May 30, 2023

Otherwise, LGTM.

@yyyyx4 yyyyx4 force-pushed the public/sparse_strategies_for_composite_elliptic_curve_isogenies branch from e3d17c3 to 17a5859 Compare May 30, 2023 07:21
@github-actions
Copy link

Documentation preview for this PR (built with commit 17a5859) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kwankyu
Copy link
Collaborator

kwankyu commented May 30, 2023

I wonder why _compute_factored_isogeny_prime_power is a hidden function. The docstring is not accessible in the reference manual. But definitely not to do here.

@yyyyx4
Copy link
Member Author

yyyyx4 commented May 30, 2023

Thanks to both of you for reviewing this!

The function is hidden because of the leading underscore; it's a common Python convention for internal functions.

@yyyyx4 yyyyx4 removed the request for review from defeo May 30, 2023 12:24
@kwankyu
Copy link
Collaborator

kwankyu commented May 30, 2023

The function is hidden because of the leading underscore; it's a common Python convention for internal functions.

I know. I wondered why it is an internal function. But never mind now. I won't.

@vbraun vbraun merged commit 43d4f83 into sagemath:develop Jun 3, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 3, 2023
@yyyyx4 yyyyx4 deleted the public/sparse_strategies_for_composite_elliptic_curve_isogenies branch October 8, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sparse strategies for composite elliptic-curve isogenies
6 participants