[is fixed] graphs: enum() functionality duplicated in relabel()

[jasongrout]

The enum() code is duplicated in relabel() for the quick option. It sure would be nice to factor that out so that the enum() code was all in one place.

Component: combinatorics

Issue created by migration from https://trac.sagemath.org/ticket/749

[rlmill]

comment:1

See ticket #729 for some relevant comments...

[rlmill]

comment:2

Or instead, just read them here:

__cmp__ ultimateley ends up using enum() twice, and this is kind of too much, since we could just look at the two graphs from lexicographically most significant, and return the answer as soon as they differ. Also, as Jason points out we should be using __eq__, __neq__, __lt__, __le__, __gt__, __ge__ instead.

[rlmill]

comment:3

Note - the quick option in the relabel function was originally an optimization for the graph_isom code, and no longer applies, since it is never used. Other than that purpose, it doesn't make sense to have it as an option, so I'll just remove it.

Here is another aspect:

sage: G._nxg.adj
{0: {1: [None]}, 1: {0: [None]}}
sage: H._nxg.adj
{0: {1: [None, None]}, 1: {0: [None, None]}}
sage: G == H
True

[rlmill]

comment:4

There is an attached patch that cleans up the whole situation.

[rlmill]

Attachment: trac749_1.patch.gz

This one first, removed quick option from relabel().

[rlmill]

This is the main overhaul.

[rlmill]

comment:5

Attachment: trac749_2.patch.gz