Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend _SupportedFindStatCollections #35968

Closed
2 tasks done
sheerluck opened this issue Jul 19, 2023 · 0 comments · Fixed by #36096
Closed
2 tasks done

Extend _SupportedFindStatCollections #35968

sheerluck opened this issue Jul 19, 2023 · 0 comments · Fixed by #36096

Comments

@sheerluck
Copy link
Contributor

Steps To Reproduce

in any env with any config run sage -t --random-seed=19 --optional=sage,internet sage/combinat/bijectionist.py

Expected Behavior

All tests passed!

Actual Behavior

Doctesting 1 file.
sage -t --long --random-seed=19 /usr/lib/python3.11/site-packages/sage/combinat/bijectionist.py
**********************************************************************
File "/usr/lib/python3.11/site-packages/sage/combinat/bijectionist.py", line 206, in sage.combinat.bijectionist
Failed example:
    findmap(list(bij.minimal_subdistributions_iterator()))            # optional -- internet
Expected:
    0: Mp00034 (quality [100])
    1: Mp00061oMp00023 (quality [100])
    2: Mp00018oMp00140 (quality [100])
Got:
    The Combinatorial Statistic Finder (https://www.findstat.org/) provides a new collection:
        Cc0030: Ordered set partitions
    To use it with this interface, it has to be added to the dictionary
        _SupportedFindStatCollections in src/sage/databases/findstat.py
    of the SageMath distribution.  Please open an issue on github!
    0: Mp00034 (quality [100])
    1: Mp00061oMp00023 (quality [100])
    2: Mp00018oMp00140 (quality [100])
**********************************************************************
1 item had failures:
   1 of 101 in sage.combinat.bijectionist
    2 not tested tests not run
    [586 tests, 1 failure, 48.94 s]

Additional Information

only when --optional=sage,internet

Environment

- **OS**:
- **Sage Version**:

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
vbraun pushed a commit to vbraun/sage that referenced this issue Aug 27, 2023
…llection

    
findstat.org supports a new collection, ordered set partitions.  This
has to be reflected by the sage interface.

Fixes sagemath#35968

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
    
URL: sagemath#36096
Reported by: Martin Rubey
Reviewer(s): Frédéric Chapoton
@mkoeppe mkoeppe added this to the sage-10.2 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants