Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.{coding,groups}: Replace imports from sage.*.all for namespace packages #34948

Closed
mkoeppe opened this issue Jan 29, 2023 · 12 comments · Fixed by #35099
Closed

sage.{coding,groups}: Replace imports from sage.*.all for namespace packages #34948

mkoeppe opened this issue Jan 29, 2023 · 12 comments · Fixed by #35099
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-10.0

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 29, 2023 •
edited
Loading

Using ./sage -fiximports from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #34201

CC: @alexchandler100 @dimpase @fchapoton

Component: refactoring

Author: Alex Chandler, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34948
@mkoeppe mkoeppe added this to the sage-9.8 milestone Jan 29, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Branch: u/mkoeppe/sage__coding_groups___replace_imports_from_sage___all_for_namespace_packages

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

New commits:

3590a19sage -fiximports src/sage/{coding,groups}

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Commit: 3590a19

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

comment:3

Lint failure is unrelated.

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 29, 2023
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from 3590a19 to 0b71513

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

1121fa3git grep -l -E ' (Q as QQ|Z as ZZ)' | xargs sed -i.bak 's/ Q as QQ/ QQ/;s/ Z as ZZ/ ZZ/;'
0d5a0e5sage.{coding,groups}: Consolidate imports from the same module
0b71513src/sage/coding/delsarte_bounds.py: Remove useless import in doctest

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

Changed author from Alex Chandler to Alex Chandler, Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

018b721sage -fiximports src/sage/{coding,groups}
a9f06e8git grep -l -E ' (Q as QQ|Z as ZZ)' | xargs sed -i.bak 's/ Q as QQ/ QQ/;s/ Z as ZZ/ ZZ/;'
00f6603sage.{coding,groups}: Consolidate imports from the same module
f38e59fsrc/sage/coding/delsarte_bounds.py: Remove useless import in doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from 0b71513 to f38e59f

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 9, 2023

This was tested successfully in https://github.com/sagemath/sagetrac-mirror/actions/runs/4038221816 (before the migration), needs review.

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#34948
36b3c89
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2023

Removed branch from the issue description; replaced by PR #35099

vbraun pushed a commit that referenced this issue Mar 19, 2023
gh-35099: sage.{coding,groups}: Replace imports from sage.*.all for n…
bcb02fe 
…amespace packages

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
Fixes #34948

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
    
URL: #35099
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging a pull request may close this issue.

sage.{coding,groups}: Replace imports from sage.*.all for namespace packages mkoeppe/sage
1 participant
@mkoeppe