GH Actions: Remove pull_request triggers for portability workflows #34942
Milestone
Comments
|
Author: Matthias Koeppe |
|
Commit: |
|
New commits:
|
This comment has been minimized.
This comment has been minimized.
|
comment:5
From https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
So I think, simply having the trigger as "pull_request" should be sufficient, or not? |
|
comment:6
In the docs workflow, "if: github.repository == 'sagemath/sagetrac-mirror'" needs to be removed as well. |
|
comment:7
Replying to Tobias Diez:
You are right; I'll simplify it. |
|
comment:9
Looks good! |
|
Reviewer: Tobias Diez |
|
comment:10
Thanks! |
This comment has been minimized.
This comment has been minimized.
mkoeppe
pushed a commit
that referenced
this issue
Feb 6, 2023
… workflows The portability tests cannot be run on every PR. Instead we need to run `build`, `doc-build` on every PR (just as we already run `lint`) We also remove the `ticket` workflow; it is not needed. Fixes sagemath/trac-to-github#157 URL: https://trac.sagemath.org/34942 Reported by: mkoeppe Ticket author(s): Matthias Koeppe Reviewer(s): Tobias Diez
|
This can be closed now. |
vbraun
pushed a commit
that referenced
this issue
May 22, 2023
…migration
…to GitHub (no more sagetrac-mirror)
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
We update the documentation on portability testing.
- Instead of referring to trac and sagetrac-mirror, we direct users to
use their personal fork
- We remove the description of a method using pull requests because
#34942 disabled it
- We update according to changed defaults on GH Actions.
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
Test running at:
https://github.com/mkoeppe/sage/actions/runs/4911075567/jobs/8768884045
(the "standard", "minimal" etc. jobs without "-pre" should now work).
URL: #35108
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik, Matthias Köppe, Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The portability tests cannot be run on every PR.
Instead we need to run
build,doc-buildon every PR (just as we already runlint)We also remove the
ticketworkflow; it is not needed.Fixes sagemath/trac-to-github#157
CC: @tobiasdiez
Component: porting
Author: Matthias Koeppe
Branch/Commit: u/mkoeppe/gh_actions__remove_pull_request_triggers_for_portability_workflows @
59033e2Reviewer: Tobias Diez
Issue created by migration from https://trac.sagemath.org/ticket/34942
The text was updated successfully, but these errors were encountered: