Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

random doctest failure in src/doc/en/thematic_tutorials/group_theory.rst #34901

Closed
yyyyx4 opened this issue Jan 9, 2023 · 9 comments
Closed

random doctest failure in src/doc/en/thematic_tutorials/group_theory.rst #34901

yyyyx4 opened this issue Jan 9, 2023 · 9 comments
Labels
c: documentation p: trivial / 5 t: bug
Milestone
sage-10.0

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Jan 9, 2023

Part of #32544:

sage -t --long --random-seed=185470747385175316039405094141387664605 src/doc/en/thematic_tutorials/group_theory.rst
**********************************************************************
File "src/doc/en/thematic_tutorials/group_theory.rst", line 207, in doc.en.thematic_tutorials.group_theory
Failed example:
    euler_phi(m*n) == euler_phi(m) * euler_phi(n)
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of 170 in doc.en.thematic_tutorials.group_theory
    [127 tests, 1 failure, 4.40 s]

(From a patchbot run in #34880.)

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: u/chapoton/34901 @ a8ee692

Reviewer: Lorenz Panny

Issue created by migration from https://trac.sagemath.org/ticket/34901
@yyyyx4 yyyyx4 added this to the sage-9.8 milestone Jan 9, 2023
@yyyyx4
Copy link
Member Author

yyyyx4 commented Jan 9, 2023

comment:1

In the test, m and n are random primes less than 10000. The test fails if and only if m == n.

@fchapoton
Copy link
Contributor

New commits:

a8ee692fix a random doctest in tutorial

@fchapoton
Copy link
Contributor

Branch: u/chapoton/34901

@fchapoton
Copy link
Contributor

Commit: a8ee692

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

ok like that ?

@yyyyx4
Copy link
Member Author

yyyyx4 commented Jan 10, 2023

comment:4

That should do. Thanks!

@yyyyx4
Copy link
Member Author

yyyyx4 commented Jan 10, 2023

Reviewer: Lorenz Panny

@kliem kliem mentioned this issue Jan 29, 2023
Open
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Feb 11, 2023
vbraun pushed a commit that referenced this issue Feb 12, 2023
Trac #34901: random doctest failure in src/doc/en/thematic_tutorials/…
fb4f2e4 
…group_theory.rst

Part of #32544:

{{{
sage -t --long --random-seed=185470747385175316039405094141387664605
src/doc/en/thematic_tutorials/group_theory.rst
**********************************************************************
File "src/doc/en/thematic_tutorials/group_theory.rst", line 207, in
doc.en.thematic_tutorials.group_theory
Failed example:
    euler_phi(m*n) == euler_phi(m) * euler_phi(n)
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of 170 in doc.en.thematic_tutorials.group_theory
    [127 tests, 1 failure, 4.40 s]
}}}

(From a patchbot run in #34880.)

URL: https://trac.sagemath.org/34901
Reported by: lorenz
Ticket author(s): Frédéric Chapoton
Reviewer(s): Lorenz Panny
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2023

Merged in 10.0.beta0

@mkoeppe mkoeppe closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-10.0
Development

No branches or pull requests
3 participants
@fchapoton @mkoeppe @yyyyx4