Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: cryptominisat 5.11 #34687

Closed
slel opened this issue Oct 22, 2022 · 2 comments · Fixed by #37669
Closed

Upgrade: cryptominisat 5.11 #34687

slel opened this issue Oct 22, 2022 · 2 comments · Fixed by #37669
Labels
c: packages: optional p: major / 3 t: enhancement
Milestone
sage-10.4

Comments

@slel
Copy link
Member

slel commented Oct 22, 2022

CryptoMiniSat 5.11 is out.

Our last upgrade was

CC: @kiwifb @slel

Component: packages: optional

Keywords: upgrade, cryptominisat

Issue created by migration from https://trac.sagemath.org/ticket/34687
@slel slel added this to the sage-9.8 milestone Oct 22, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Dec 31, 2022
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
@dimpase
Copy link
Member

dimpase commented Mar 25, 2024

meanwhile the latest version is 5.11.21, released in Feb 2024

@dimpase
Copy link
Member

dimpase commented Mar 25, 2024

and it uses toml rather than tomli, which means that we either need a patch, or adding toml as a package.

This was referenced Mar 25, 2024
Closed
Merged
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 8, 2024
sagemathgh-37669: update (py)cryptominisat to version 5.11.21, remove…
ae87c7f 
… no longer needed cryptominisat spkg

    
Fixes sagemath#34687
As pycryptosat is now a PyPI package, convert it to a pip package, and
remove cryptominisat
### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
    
URL: sagemath#37669
Reported by: Dima Pasechnik
Reviewer(s): Dima Pasechnik, Matthias Köppe
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging a pull request may close this issue.

update (py)cryptominisat to version 5.11.21, remove no longer needed cryptominisat spkg dimpase/sage
3 participants
@dimpase @slel @mkoeppe