Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with multiplication of points on elliptic curves over Integers(n) #34681

Closed
tornaria opened this issue Oct 20, 2022 · 10 comments
Closed

Error with multiplication of points on elliptic curves over Integers(n) #34681

tornaria opened this issue Oct 20, 2022 · 10 comments

Comments

@tornaria
Copy link
Contributor

sage: E = EllipticCurve(Integers(11*19), [1,0])
sage: P = E(93,3)
sage: P + P
(5 : 118 : 1)
sage: 2 * P
...
AttributeError: 'EllipticCurve_generic_with_category' object has no attribute 'base_field'

CC: @yyyyx4

Component: number theory

Author: Gonzalo Tornaría

Branch/Commit: 9bbacfe

Reviewer: Lorenz Panny

Issue created by migration from https://trac.sagemath.org/ticket/34681

@tornaria tornaria added this to the sage-9.8 milestone Oct 20, 2022
@tornaria
Copy link
Contributor Author

Commit: 6d31aad

@tornaria
Copy link
Contributor Author

Author: Gonzalo Tornaría

@tornaria
Copy link
Contributor Author

Branch: u/tornaria/34681

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2022

Changed commit from 6d31aad to 9bbacfe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

eb5833f#34681: fix multiplication of points over Integers(n)
9bbacfe#34681: do not redo multiplication when pari fails

@yyyyx4
Copy link
Member

yyyyx4 commented Oct 21, 2022

comment:3

Related: #33228

@tornaria
Copy link
Contributor Author

comment:4

Replying to Lorenz Panny:

Related: #33228

Thanks for the info. Looks quite interesting. However, this fix here seems trivial -- can we get this in? At the very least the first commit.

Also, given that pari ellmul works with integer mod composite (in the sense that it either gives the right answer or gives a Fp_inv error) it seems a pity to fall back to a generic implementation as in #33228.

Same as mentioned in #33228, this was spotted by a student trying to implement ECM. It seems an important application... If point multiplication is implemented via ellmul this means the students might even have a shot at getting good speed if they can figure out how to choose the parameters.

@yyyyx4
Copy link
Member

yyyyx4 commented Nov 3, 2022

comment:5

Replying to Gonzalo Tornaría:

However, this fix here seems trivial -- can we get this in?

Indeed, why not.

@yyyyx4
Copy link
Member

yyyyx4 commented Nov 3, 2022

Reviewer: Lorenz Panny

@vbraun
Copy link
Member

vbraun commented Nov 7, 2022

Changed branch from u/tornaria/34681 to 9bbacfe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants